@John *******
you are not using two passports as the old one is cancelled. You just carry the old one to show the visa. Its not wrong I've done it in Thailand as advised by immigration there.
As long as the visa is valid for the time you are travelling.
I will be doing exactly that in a couple of weeks.
Example, passport expires with 6 months of a year's visa still valid.
New passport issued.
Travel with both cancelled passport and new passport. Show both at immigration at entry, no problem.